Gramhagen/xlearn docker fix #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versions, also switching to just use aptitude
gramhagen
requested review from
anargyri,
loomlike and
miguelgfierro
as code owners
|
i tried a few variation of installing compilers through anaconda, but can't get anything to work seamlessly. i think the easiest solution is still having the user install cmake separately through the notes. the docker version works fine so I will go ahead and merge this. |
gramhagen
added a commit
that referenced
this pull request
Jul 21, 2020
* optimize dkn * fix bug in prediction * update notebook * add use entity parameter * change notebook * update a quick start on MINDsmall dataset * Gramhagen/xlearn docker fix (#1146) * moving cmake installation later in docker so it is available for all versions, also switching to just use aptitude * updating setup instructions for xlearn cmake dependency * reverting vscode auto-formatting of setup.md table of contents * fix bug and change his_size to history size * fix bug his_size to history size * Update dkn_MIND_dataset.ipynb Minor grammatical edits. * change his_size to history_size in notebook * adding mind competition link to readme (#1148) * adding mind competition link to readme * Update README.md some edits on the text * adding intro section in readme * removing divider in readme * Update README.md Co-authored-by: wutaomsft <21267949+wutaomsft@users.noreply.github.com> Co-authored-by: Miguel González-Fierro <3491412+miguelgfierro@users.noreply.github.com> Co-authored-by: FAREAST\v-danyal <v-danyal@microsoft.com> Co-authored-by: Miguel González-Fierro <3491412+miguelgfierro@users.noreply.github.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: wutaomsft <21267949+wutaomsft@users.noreply.github.com> Co-authored-by: LeavingSeason <jialia@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes setup instructions for cmake and adjust docker installation of cmake to handle gpu docker version
Related Issues
#1143
#1121
Checklist:
stagingand notmaster.