Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DKN quick start notebook and deep dive #1165

Merged
merged 35 commits into from
Jul 31, 2020
Merged

DKN quick start notebook and deep dive #1165

merged 35 commits into from
Jul 31, 2020

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Jul 27, 2020 •
edited

Description

DKN quick start notebook and deep dive

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

@Leavingseason
Copy link
Collaborator

Leavingseason commented Jul 27, 2020 •
edited

To avoid a transition gapping, I suggest the new deep dive change should be merged into this PR. The removed codes are critical instructions for users to quickly start with MIND dataset.

@miguelgfierro miguelgfierro changed the title DKN quick start notebook simplified DKN quick start notebook and deep dive Jul 28, 2020
@danyang-liu
Copy link
Contributor

Thanks, looks good

@miguelgfierro miguelgfierro merged commit e452fef into staging Jul 31, 2020
@miguelgfierro miguelgfierro deleted the dkn_fix branch July 31, 2020 17:22
@miguelgfierro miguelgfierro mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

@Leavingseason Leavingseason Awaiting requested review from Leavingseason

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miguelgfierro @Leavingseason @danyang-liu