Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated MIND tests and others #1236

Merged
merged 8 commits into from
Nov 9, 2020
Merged

Updated MIND tests and others #1236

merged 8 commits into from
Nov 9, 2020

Conversation

wutaomsft
Copy link
Collaborator

@wutaomsft wutaomsft commented Nov 8, 2020 •
edited
Loading

Description

  1. Added pytest.ini to reduce number of warnings
  2. Minor update on mind.py (more to come)
  3. MIND dataset tests additions and improvements.
    a. Added smoke tests for testing URL exists for all 9 files in three dataset sizes (demo, small, large).
    b. Improved coverage for extract file tests
    c. Removed repetitive tests that only downloaded but did not extract
  4. Updated search query for testing negative query on wiki (the previous query now generates a definitive entity_id)

Related Issues

#1221

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

@wutaomsft wutaomsft changed the title Wutao/testdemo Updated MIND tests and others Nov 8, 2020
miguelgfierro
miguelgfierro approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool!

@miguelgfierro miguelgfierro merged commit 82be3aa into staging Nov 9, 2020
@miguelgfierro miguelgfierro deleted the wutao/testdemo branch November 9, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wutaomsft @miguelgfierro