Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off TF warnings #1276

Merged
merged 16 commits into from Jan 18, 2021
Merged

turn off TF warnings #1276

merged 16 commits into from Jan 18, 2021

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Jan 8, 2021

Description

Related Issues

fixes #1256

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to master branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wutaomsft
Copy link
Collaborator

Wonder if we want to clean up output of the notebook before checking in? Asking as a general question.

@miguelgfierro
Copy link
Collaborator Author

Wonder if we want to clean up output of the notebook before checking in? Asking as a general question.

Not sure if you refer to the warning outputs of Tensorflow, in that case, they should be cleaned with the latest changes. If you refer to completely erase the output of all the notebooks, we had a discussion about that matter some months ago, we decided to leave the outputs because it helped the user understand each notebook and algorithm. We can have the discussion again if you consider it

@miguelgfierro miguelgfierro merged commit 0a844d3 into staging Jan 18, 2021
@miguelgfierro miguelgfierro deleted the miguel/tf_warning branch January 18, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants