Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andreas/docs #1426

Merged
merged 42 commits into from
Jun 3, 2021
Merged

Andreas/docs #1426

merged 42 commits into from
Jun 3, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Jun 3, 2021 •
edited
Loading

Description

  • Fixed the docstrings under dataset and evaluation. Added missing ones.
  • Renamed the method that downloads Glove.

This branch is up to date with pipeline_release; maybe we want to merge it there?

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

miguelgfierro and others added 30 commits May 28, 2021 10:49
@miguelgfierro
🐛 in installation process and in test execution
d9a4c8c
@miguelgfierro
make sure we are using the package when running the test 🐛
8aea5a9
@miguelgfierro
tag
afbde93
@miguelgfierro
xlearn 🐛
756bc8d
@miguelgfierro
trying to remove exit -1
1c26389
@miguelgfierro
trying to remove exit -1 🐛
8bc0871
@miguelgfierro
Remove html files in docs from being pushed
80c9f8b
@miguelgfierro
trying to remove exit -1 🐛🐛
150f94a
@miguelgfierro
trying to remove exit -1 failOnStderr
fbc9c58
@miguelgfierro
trying to remove exit -1 💥
9005a8f
@miguelgfierro
Merge pull request #1419 from microsoft/miguelgfierro-patch-1
ee387fe 
Remove html files in docs from being pushed
@miguelgfierro
trying to remove exit -1 💥💥
c03fcb2
@miguelgfierro
new full run xlearn in
3626675
@miguelgfierro
trigger tag 🐛
4f32505
@anargyri
Merge branch 'zhangya' into andreas/docs
d17b2e2
@anargyri
Edit CONTRIBUTING.md
0b56527
@miguelgfierro
backoff
b2c8bc0
@miguelgfierro
📝
a596364
@miguelgfierro
Merge pull request #1420 from microsoft/miguel/retry_maybedownload
e18c138 
Retry to maybe download
@miguelgfierro
fix conflict and keep non-alphabetical order following @anargyri advice
0aad35d
@miguelgfierro
review 📝 in common
966a683
@miguelgfierro
wip
0c5682d
@anargyri
Merge branch 'zhangya' into andreas/docs
a77d2b4
@miguelgfierro
deprec
3684161
@miguelgfierro
fix 📝
f6f30ed
@miguelgfierro
removing dev branch, will trigger only with tag
a95c898
@anargyri
Fix docstrings in dataset and evaluation
1c4953d
@anargyri
Merge branch 'miguel/review_docs' into andreas/docs
0e684e9
@anargyri
Merge branch 'zhangya' into andreas/docs
6c92d65
@anargyri
Fix ** in docstring
0e704d7
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@YanZhangADS YanZhangADS merged commit 94d23fc into zhangya Jun 3, 2021
@YanZhangADS YanZhangADS deleted the andreas/docs branch June 3, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramhagen gramhagen Awaiting requested review from gramhagen

@loomlike loomlike Awaiting requested review from loomlike

@miguelgfierro miguelgfierro Awaiting requested review from miguelgfierro

@wutaomsft wutaomsft Awaiting requested review from wutaomsft

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anargyri @YanZhangADS @miguelgfierro