Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release process #1445

Merged
merged 9 commits into from
Jun 16, 2021
Merged

Release process #1445

merged 9 commits into from
Jun 16, 2021

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

SETUP.md Outdated Show resolved Hide resolved
SETUP.md Outdated
Comment on lines 345 to 346
1. Make sure that the code in main passes all the tests (unit and nightly tests).
2. Update the version number in [reco_utils.py/__init__.py](reco_utils.py/__init__.py)
Copy link
Collaborator

@gramhagen gramhagen Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to modify the version from staging?

Suggested change
1. Make sure that the code in main passes all the tests (unit and nightly tests).
2. Update the version number in [reco_utils.py/__init__.py](reco_utils.py/__init__.py)
1. Start with staging branch (all unit and nightly tests should be green)
1. Update the version number in [reco_utils.py/__init__.py](reco_utils.py/__init__.py)
1. Push PR back to staging
1. Wait for PR to merge to staging
1. Create new PR from staging to main
1. Wait for PR to merge to main branch
1. Check out updated main branch

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to come up with something simple

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gramhagen I made some changes in this part

@miguelgfierro miguelgfierro merged commit c41524f into staging Jun 16, 2021
@miguelgfierro miguelgfierro deleted the miguel/release_process branch June 16, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants