Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reco utils to recommenders #1485

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Conversation

miguelgfierro
Copy link
Collaborator

Description

I have run all the tests locally, and they work

FYI @laserprec

Related Issues

#1477
#1390

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

@miguelgfierro miguelgfierro merged commit b71833d into staging Jul 26, 2021
@miguelgfierro miguelgfierro deleted the miguel/reco_utils_to_recommenders branch July 26, 2021 17:03
@miguelgfierro miguelgfierro mentioned this pull request Jul 27, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants