Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpu build #1499

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Add gpu build #1499

merged 3 commits into from
Aug 17, 2021

Conversation

laserprec
Copy link
Contributor

@laserprec laserprec commented Aug 17, 2021

Description

To improve developer experience working with this repo, we will begin migrating our DevOps pipelines into Github Action, along with consolidating documentations and leveraging popular DevOps tools like tox and flake8. This will be a sequence of updates to our DevOps infrastructures:

  1. Propose and draft the CI pipeline in Github Action
  2. Setup self-hosted machines to run our GPU workloads <---- (Current PR)
  3. Run tests on the appropriate dependency subsets
  4. Create feature parity with the existing CI pipelines (pr-gates & nightly-build)
  5. Optimize build time for unit tests
  6. Enforce flake8 (coding style checks) on the build and clean up coding styles to pass flake8 checks
  7. Deprecate CI pipelines in ADO and switch to Github Actions

In THIS PR

we have the following changes:

  • Add a GPU build step to PR-gate

image

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions. (N/A)
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@laserprec laserprec linked an issue Aug 17, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #1499 (7dc915e) into staging (f040b0f) will increase coverage by 27.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           staging    #1499       +/-   ##
============================================
+ Coverage    34.36%   61.96%   +27.59%     
============================================
  Files           84       84               
  Lines         8368     8368               
============================================
+ Hits          2876     5185     +2309     
+ Misses        5492     3183     -2309     
Impacted Files Coverage Δ
recommenders/datasets/movielens.py 75.84% <0.00%> (+3.93%) ⬆️
...ecommenders/models/newsrec/io/mind_all_iterator.py 12.21% <0.00%> (+4.96%) ⬆️
recommenders/models/newsrec/io/mind_iterator.py 15.67% <0.00%> (+5.40%) ⬆️
recommenders/datasets/pandas_df_utils.py 94.89% <0.00%> (+8.02%) ⬆️
...ommenders/models/deeprec/io/sequential_iterator.py 15.85% <0.00%> (+8.37%) ⬆️
recommenders/models/newsrec/models/base_model.py 30.90% <0.00%> (+13.93%) ⬆️
...commenders/models/deeprec/io/nextitnet_iterator.py 22.68% <0.00%> (+15.12%) ⬆️
...ls/deeprec/models/sequential/rnn_cell_implement.py 28.36% <0.00%> (+18.43%) ⬆️
...ders/models/deeprec/models/sequential/sum_cells.py 45.51% <0.00%> (+25.51%) ⬆️
recommenders/models/newsrec/models/layers.py 53.38% <0.00%> (+30.50%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e67f3a...7dc915e. Read the comment docs.

@laserprec laserprec merged commit 3e23511 into staging Aug 17, 2021
@miguelgfierro miguelgfierro deleted the laserprec/gpu-ci branch August 24, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gpu build step to Github Action CI
3 participants