Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtualenv support and info #1520

Merged
merged 17 commits into from
Sep 9, 2021
Merged

Add virtualenv support and info #1520

merged 17 commits into from
Sep 9, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Sep 6, 2021

Description

Modifications required to support virtualenv which is an extension of venv but differs somewhat in installation.

  • Tested installation and updated the SETUP and README documentation.
  • Modified the dockerfile to support virtualenv and tested docker containers.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +35 to +39
databricks_cli>=0.8.6,<1
pyarrow>=0.8.0,<1.0.0
pyspark>=2.4.5,<3.0.0
cmake>=3.18.4.post1
xlearn==0.40a1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this is merged into staging, a new documentation job will be triggered. In the past I had problems when using pyspark and readthedocs. We should check if this causes a problem this time, FYI @YanZhangADS

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a DSVM, compilation works and the docs look ok on Firefox Let's check on readthedocs too after the merge.

@codecov-commenter
Copy link

Codecov Report

Merging #1520 (31d36f2) into staging (c5029af) will decrease coverage by 12.28%.
The diff coverage is n/a.

❗ Current head 31d36f2 differs from pull request most recent head 0aca010. Consider uploading reports for the commit 0aca010 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           staging    #1520       +/-   ##
============================================
- Coverage    74.23%   61.95%   -12.29%     
============================================
  Files           84       84               
  Lines         8369     8369               
============================================
- Hits          6213     5185     -1028     
- Misses        2156     3184     +1028     
Impacted Files Coverage Δ
...ecommenders/models/newsrec/io/mind_all_iterator.py 12.21% <0.00%> (-86.65%) ⬇️
recommenders/models/newsrec/io/mind_iterator.py 15.67% <0.00%> (-82.71%) ⬇️
...ommenders/models/deeprec/io/sequential_iterator.py 15.85% <0.00%> (-81.94%) ⬇️
recommenders/models/newsrec/models/base_model.py 30.90% <0.00%> (-59.40%) ⬇️
...deeprec/models/sequential/sequential_base_model.py 46.97% <0.00%> (-47.66%) ⬇️
recommenders/models/geoimc/geoimc_data.py 41.66% <0.00%> (-44.80%) ⬇️
...enders/models/deeprec/io/dkn_item2item_iterator.py 45.61% <0.00%> (-42.11%) ⬇️
...menders/models/deeprec/models/graphrec/lightgcn.py 51.47% <0.00%> (-40.24%) ⬇️
recommenders/datasets/mind.py 0.00% <0.00%> (-30.85%) ⬇️
recommenders/datasets/movielens.py 75.84% <0.00%> (-15.17%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5029af...0aca010. Read the comment docs.

@anargyri anargyri merged commit a8c81fe into staging Sep 9, 2021
@anargyri anargyri deleted the andreas/virtual_env branch September 9, 2021 08:43
@miguelgfierro miguelgfierro mentioned this pull request Sep 9, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants