Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TensorFlow 2.6 upgrade #1565

Merged
merged 66 commits into from
Dec 6, 2021
Merged

TensorFlow 2.6 upgrade #1565

merged 66 commits into from
Dec 6, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Nov 4, 2021

Description

Changes required for upgrade to TensorFlow 2.6. This is a migration of the existing code to TF2 keeping the v1 style and using the tf.compat.v1 API. See https://www.tensorflow.org/guide/migrate/upgrade and https://www.tensorflow.org/guide/migrate.

In detail

  • Ran update script provided by TensorFlow that replaces syntax and fixed any errors caused.
  • Replaced references from tf.contrib (now deprecated) with other modules or packages
  • Edited setup.py, conda script and documentation.
  • Made changes to some classes (e.g. DKN, LSTUR) to work.
  • Replaced tf.summary, tf.logging, hparams.
  • Replaced batch_dot() to fix self attention layer.
  • Replaced optimizers that were not working e.g. LazyAdam.
  • Replaced deprecated imports of RNN cells.
  • Replaced fully connected layer with tf-slim implementation.
  • Pinned commit from pymanopt in order to fix GeoIMC.
  • Removed batch inference step from SLIRec notebook.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@Leavingseason
Copy link
Collaborator

Great job! I have tested some deeprec-related jupyter-notebooks, and everything is running normally.

@@ -575,6 +576,11 @@ def extract_movielens(size, rating_path, item_path, zip_path):
shutil.copyfileobj(zf, f)


# For more information on data synthesis, see https://pandera.readthedocs.io/en/latest/data_synthesis_strategies.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! ❤️

@miguelgfierro
Copy link
Collaborator

@anargyri, it's weird, do you know why the ADO pipelines are not being executed?

@anargyri
Copy link
Collaborator Author

anargyri commented Dec 1, 2021

@anargyri, it's weird, do you know why the ADO pipelines are not being executed?

The GitHub hosts don't have CUDA 11 installed. About spark, I am not sure, I am trying to figure what happens.

@miguelgfierro
Copy link
Collaborator

The GitHub hosts don't have CUDA 11 installed. About spark, I am not sure, I am trying to figure what happens.

But the ADO pipelines should execute. This is weird

@anargyri
Copy link
Collaborator Author

anargyri commented Dec 2, 2021

The GitHub hosts don't have CUDA 11 installed. About spark, I am not sure, I am trying to figure what happens.

But the ADO pipelines should execute. This is weird

Ah sorry, I missed the "ADO" in your question. Yes, it is strange, let me double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants