Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model save in RBM #1618

Merged
merged 9 commits into from
Jan 21, 2022
Merged

Model save in RBM #1618

merged 9 commits into from
Jan 21, 2022

Conversation

pradnyeshjoshi
Copy link
Collaborator

@pradnyeshjoshi pradnyeshjoshi commented Jan 20, 2022

Description

  1. Added save function to rbm.py: This writes model checkpoints to a specified directory.
  2. Added load function to rbm.py: This gives users ability to instantiate a model class, load checkpoints from a pretrained model and resume training.
  3. Added code snippet for how to use save and load functions to the RBM quick start notebook.

Related Issues

  1. [FEATURE] Model save in RBM #878
  2. [FEATURE] Export RBM model #1510

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #1618 (6bf139c) into staging (9dec57e) will decrease coverage by 0.01%.
The diff coverage is 73.91%.

❗ Current head 6bf139c differs from pull request most recent head 950172d. Consider uploading reports for the commit 950172d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1618      +/-   ##
===========================================
- Coverage    59.12%   59.10%   -0.02%     
===========================================
  Files           88       88              
  Lines         8942     8953      +11     
===========================================
+ Hits          5287     5292       +5     
- Misses        3655     3661       +6     
Flag Coverage Δ
pr-gate 59.10% <73.91%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/models/rbm/rbm.py 80.00% <73.91%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cb35b...950172d. Read the comment docs.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing @pradnyeshjoshi, brutal timing!

Just a minor comment with tests

examples/00_quick_start/models/checkpoint Outdated Show resolved Hide resolved
recommenders/models/rbm/rbm.py Outdated Show resolved Hide resolved
recommenders/models/rbm/rbm.py Outdated Show resolved Hide resolved
tests/unit/recommenders/models/test_rbm.py Show resolved Hide resolved
recommenders/models/rbm/rbm.py Outdated Show resolved Hide resolved
@pradnyeshjoshi pradnyeshjoshi marked this pull request as draft January 20, 2022 17:44
@pradnyeshjoshi pradnyeshjoshi marked this pull request as ready for review January 20, 2022 20:31
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vamos!!!

@miguelgfierro miguelgfierro merged commit 02451f1 into staging Jan 21, 2022
@miguelgfierro miguelgfierro deleted the pradjoshi/save_rbm branch January 21, 2022 08:50
This was referenced Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants