Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back scikit-surprise to dependencies #1630

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Add back scikit-surprise to dependencies #1630

merged 4 commits into from
Feb 3, 2022

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Feb 3, 2022 •
edited

Description

Surprise has been disabled from setup.py because of an incompatibility with numpy 1.19.
I tested again surprise after the latest changes in the setup and the tests pass.

Related Issues

#1511

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

miguelgfierro
miguelgfierro approved these changes Feb 3, 2022
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, this is interesting. Out of curiosity, what has changed?

@anargyri
Copy link
Collaborator Author

anargyri commented Feb 3, 2022

mmm, this is interesting. Out of curiosity, what has changed?

Not sure, but I suspect that maybe separating the Python environments 3.6 and >=3.7 did the trick.
Let's see if it passes through the pipelines though. I am not sure it wasn't something specific to the VM I used.

@anargyri anargyri merged commit 7425d21 into staging Feb 3, 2022
@miguelgfierro miguelgfierro deleted the andreas/surprise branch February 3, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anargyri @miguelgfierro