Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov Fix #1665

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Codecov Fix #1665

merged 3 commits into from
Mar 9, 2022

Conversation

laserprec
Copy link
Contributor

@laserprec laserprec commented Mar 9, 2022

Description

Resolves the following issue when merging code coverage reports generated in self-hosted (aml) runners.

"CoverageWarning: Couldn't parse 
 '/home/azureuser/runner/work/recommenders/recommenders/recommenders/evaluation/__init__.py': No source for code"

Also add -i flag to ignore the "No source for code" error.

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@laserprec laserprec changed the base branch from main to staging March 9, 2022 14:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #1665 (0fa2ccf) into staging (afd0597) will decrease coverage by 34.76%.
The diff coverage is 100.00%.

❗ Current head 0fa2ccf differs from pull request most recent head c99afa7. Consider uploading reports for the commit c99afa7 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##           staging    #1665       +/-   ##
============================================
- Coverage    57.97%   23.20%   -34.77%     
============================================
  Files           88       88               
  Lines         9096     9101        +5     
============================================
- Hits          5273     2112     -3161     
- Misses        3823     6989     +3166     
Flag Coverage Δ
pr-gate 23.20% <100.00%> (-34.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/models/lightfm/lightfm_utils.py 62.50% <ø> (ø)
recommenders/datasets/spark_splitters.py 87.27% <100.00%> (+1.55%) ⬆️
recommenders/models/sar/sar_singlenode.py 96.85% <100.00%> (-0.02%) ⬇️
...enders/models/deeprec/models/sequential/sli_rec.py 0.00% <0.00%> (-100.00%) ⬇️
...ders/models/deeprec/models/sequential/nextitnet.py 0.00% <0.00%> (-100.00%) ⬇️
...commenders/models/deeprec/models/sequential/sum.py 0.00% <0.00%> (-96.50%) ⬇️
recommenders/models/ncf/ncf_singlenode.py 2.29% <0.00%> (-96.19%) ⬇️
recommenders/models/newsrec/models/npa.py 0.00% <0.00%> (-95.59%) ⬇️
recommenders/models/wide_deep/wide_deep_utils.py 0.00% <0.00%> (-93.55%) ⬇️
recommenders/models/newsrec/models/naml.py 0.00% <0.00%> (-92.44%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60426b4...c99afa7. Read the comment docs.

@laserprec laserprec merged commit d95baf8 into staging Mar 9, 2022
@laserprec laserprec deleted the laserprec/code-cov-fix branch March 9, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants