Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ssept model path & citation #1678

Merged
merged 4 commits into from
Mar 25, 2022
Merged

Added ssept model path & citation #1678

merged 4 commits into from
Mar 25, 2022

Conversation

aeroabir
Copy link
Collaborator

Description

In the examples\sasrec_amazon.ipynb notebook added the path for SSEPT (Personalized Transformer) model. Also added the citation of the same paper.

Related Issues

NA.

Checklist:

  • [ x] I have followed the contribution guidelines and code style for this project.
  • [ x] I have added tests covering my contributions.
  • [ x] I have updated the documentation accordingly.
  • [ x] This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some small comments, but overall is great!

examples/00_quick_start/sasrec_amazon.ipynb Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #1678 (08a9eba) into staging (93c9df2) will increase coverage by 23.09%.
The diff coverage is 6.66%.

❗ Current head 08a9eba differs from pull request most recent head 19edc07. Consider uploading reports for the commit 19edc07 to get more accurate results

@@             Coverage Diff              @@
##           staging    #1678       +/-   ##
============================================
+ Coverage     0.00%   23.09%   +23.09%     
============================================
  Files           88       87        -1     
  Lines         9101     9106        +5     
============================================
+ Hits             0     2103     +2103     
- Misses           0     7003     +7003     
Flag Coverage Δ
nightly ?
pr-gate 23.09% <6.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/split_utils.py 68.75% <6.66%> (+68.75%) ⬆️
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/movielens.py 66.37% <0.00%> (+66.37%) ⬆️
recommenders/datasets/download_utils.py 90.00% <0.00%> (+90.00%) ⬆️
recommenders/models/newsrec/io/mind_iterator.py 0.00% <0.00%> (ø)
recommenders/models/newsrec/models/base_model.py 0.00% <0.00%> (ø)
recommenders/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c9df2...19edc07. Read the comment docs.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

recommenders/datasets/split_utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geat job @aeroabir

@anargyri anargyri merged commit a3627e7 into staging Mar 25, 2022
@miguelgfierro miguelgfierro deleted the staging_abir_ssept branch March 25, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants