Delete tox.ini #1799
Delete tox.ini #1799
Conversation
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
|
|
||
|
|
||
| # Configurations for running pytest | ||
| [pytest] |
There was a problem hiding this comment.
I am okay with deleting but tox also stores configuration related to other python tools like pytest and flake8. Maybe the error is relating them. Do you think we would need any of these configurations?
There was a problem hiding this comment.
I would ask back a question, is there anything in the tox that we can reused in the workflow that @pradnyeshjoshi did https://github.com/microsoft/recommenders/tree/main/.github/workflows
| # reports all (except passed tests). See https://docs.pytest.org/en/latest/usage.html#detailed-summary-report | ||
| -ra | ||
| --durations 10 | ||
| --cov-append --cov=recommenders --cov-report=term --cov-report=xml --junitxml=junit/test-results.xml |
There was a problem hiding this comment.
I think by default we report code coverage at the end of the tests. Maybe the error you are seeing is relating to missing the coverage package?
There was a problem hiding this comment.
@pradnyeshjoshi in the AzureML tests, do we have coverage report?
Description
I think we are not using tox anymore. Earlier today I tried to run the tests with pytest, and I got an error because I have this file. Should we erase it?
FYI @laserprec
Related Issues
Checklist:
staging branchand not tomain branch.