Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace append with pd.concat #1811

Conversation

gro1m
Copy link
Contributor

@gro1m gro1m commented Aug 11, 2022

Description

Execution of data = ImplicitCF(train, test, seed, col_user, col_item, col_rating) issues the following warning:

/anaconda/envs/ncf-microsoft-env/lib/python3.9/site-packages/recommenders/models/deeprec/DataModel/ImplicitCF.py:73: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
  df = train if test is None else train.append(test)

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • [Not Applicable] I have added tests covering my contributions.
  • [Not Applicable] I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@miguelgfierro miguelgfierro merged commit 06be8bc into recommenders-team:staging Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants