Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in nightly spark: add env PYSPARK #1899

Merged
merged 41 commits into from
Mar 30, 2023

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Mar 9, 2023

Description

Fix the error in the nightly build in the benchmark notebook for Spark

Related Issues

Fix #1898

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator Author

Nightly working: https://github.com/microsoft/recommenders/actions/runs/4563686982/jobs/8052496808

Kudos to @loomlike

@miguelgfierro miguelgfierro marked this pull request as ready for review March 30, 2023 13:10
@@ -146,8 +147,7 @@
#
"tests/smoke/examples/test_notebooks_pyspark.py::test_als_pyspark_smoke", # 49.53s
"tests/integration/examples/test_notebooks_pyspark.py::test_als_pyspark_integration", # 110.58s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have other spark tests been passed with AzureML while the benchmark one failed? interesting....

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, honestly, maybe it spark is an early evil AGI or something lol

Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@miguelgfierro miguelgfierro merged commit e14f739 into staging Mar 30, 2023
22 checks passed
@miguelgfierro miguelgfierro deleted the miguel/error_spark_benchmark branch March 30, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants