Update multinomial_vae.py #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staging to main: improvements in testing pipeline and documentation
corrected import for Adam optimizer
kone807
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike,
wutaomsft and
simonzhaoms
as code owners
|
hey @miguelgfierro, this and changing line 294 by adding legacy before adam in recommenders/models/vae/standard_vae.py fixes the errors and the code executes correctly with proper results. |
|
do you want to push the change in the file |
|
@microsoft-github-policy-service agree @miguelgfierro committed the changes. The current version works fine at my end, for both standard vae and multi vae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrected import for Adam optimizer
Description
Related Issues
References
Checklist:
staging branchand not tomain branch.