Add a section in the readme for developers #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike,
wutaomsft and
simonzhaoms
as code owners
wutaomsft
reviewed
Apr 22, 2023
SETUP.md
Outdated
| @@ -34,6 +34,24 @@ pip install recommenders[examples,spark] | |||
| # c. Run the notebook. | |||
| ``` | |||
|
|
|||
| ## Setup for developers | |||
There was a problem hiding this comment.
Capitalize d in developers for consistency
wutaomsft
approved these changes
Apr 24, 2023
SETUP.md
Outdated
| @@ -34,6 +34,24 @@ pip install recommenders[examples,spark] | |||
| # c. Run the notebook. | |||
| ``` | |||
|
|
|||
| ## Setup for developers | |||
There was a problem hiding this comment.
I wonder if it is better to move this section towards later part of the doc. Maybe right before the content related to making a release? And make this a top-level section of Setup for Developers of the Repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1921
Related Issues
References
Checklist:
staging branchand not tomain branch.