Make early_stopping a callable in LightGBM #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
hi @StrikerRUS @guolinke, we added early stopping as a callable. Right now we have |
miguelgfierro
commented
Aug 18, 2023
| "name": "stderr", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "/home/u/anaconda/envs/recommenders/lib/python3.9/site-packages/lightgbm/engine.py:181: UserWarning: 'early_stopping_rounds' argument is deprecated and will be removed in a future release of LightGBM. Pass 'early_stopping()' callback via 'callbacks' argument instead.\n", |
There was a problem hiding this comment.
checked that the code works with LightGBM 2.2.1 https://github.com/microsoft/LightGBM/blob/v2.2.1/python-package/lightgbm/callback.py. We can leave the dependency untouched
wutaomsft
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Fix #1965
References
Checklist:
staging branchand not tomain branch.