Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py with supported OS #1974

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Update setup.py with supported OS #1974

merged 2 commits into from
Aug 29, 2023

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Aug 23, 2023 •
edited
Loading

Description

Remove Windows and MacOS from supported OS

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Remove windows from supported OS
589d130 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Remove MacOS from supported OS
4ae0aaa 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro miguelgfierro marked this pull request as ready for review August 23, 2023 09:44
loomlike
loomlike approved these changes Aug 27, 2023
View reviewed changes
Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@miguelgfierro miguelgfierro merged commit 0cfe1b4 into staging Aug 29, 2023
22 of 29 checks passed
@miguelgfierro miguelgfierro deleted the miguel/setup2 branch August 29, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loomlike loomlike loomlike approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miguelgfierro @loomlike