License update #1978
Merged
License update #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
miguelgfierro
commented
Aug 25, 2023
LICENSE
Outdated
| @@ -1,6 +1,7 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Copyright (c) 2018-present Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
This follows the convention of PyTorch, see https://github.com/pytorch/pytorch/blob/main/LICENSE
There was a problem hiding this comment.
The feedback from Justin is that it is ok, and that we can remove the "All right reserved"
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
|
FYI @ibrahimhaddad in case you want to review |
loomlike
approved these changes
Aug 29, 2023
| @@ -1,6 +1,7 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) Microsoft Corporation. All rights reserved. | |||
| Copyright (c) 2018-present Microsoft Corporation. | |||
There was a problem hiding this comment.
is this present correct? or should this be 2018-2023?
There was a problem hiding this comment.
Not 2023, because otherwise we will need to update it every year. In PyTorch they put present https://github.com/pytorch/pytorch/blob/main/LICENSE#L15. I have also seen 2018- or 2018.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewing this with Justin, once he approves, I'll update the rest of the files
Related Issues
References
Checklist:
staging branchand not tomain branch.