Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging to main: Remove support for Python 3.7 and redefinition of tests #1998

Merged
merged 84 commits into from
Sep 26, 2023
Merged

Staging to main: Remove support for Python 3.7 and redefinition of tests #1998

merged 84 commits into from
Sep 26, 2023

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

miguelgfierro and others added 30 commits September 1, 2023 12:41
@miguelgfierro
Integrate exmaples in core package
9441577 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Add GPU installation details
339f25b 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
📝
5b6ac71 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Remove examples from tests
19cfa7d 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Merge pull request #1987 from recommenders-team/miguel/examples_default
2ff0713 
Merging the extra_requires examples into the core package
@miguelgfierro
Refactor data validation tests
5f18cae 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@SimonYansenZhao
Upgrade dependencies, remove support for python 3.7 and add python 3.11
284a9ff 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Use numpy>=1.23.3 for Python 3.11
73a47c2 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Remove support for Python 3.11
bfd9336 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Remove constraint on hypothesis
3ce6f03 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Try only Python 3.8 and 3.9
a870c4f 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Set atol and rtol
e7447f9 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Set pandas<1.6
418f4b0 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Replace is_sequence() with is_nested()
18c89aa 
is_sequence() is deleted in TensorFlow 2.13.0.  See
https://github.com/tensorflow/tensorflow/releases/tag/v2.13.0

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Revert dependency versions
1c6a1ff 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Lower version of category-encoders
7b2d9ff 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Loose dependency upper versions
96bdaa3 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Use newer version of transformers
67da0b5 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Correct min_df in recommenders.models.tfidf.tfidf_utils.TfidfRecommen…
12f1eda 
…der.tokenize_text()

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Set fastai<2
97deed1 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Revert dependency versions
1371084 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Update
659ac17 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Only drop the support for Python 3.7
edfa101 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Update versions
31a8b3d 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@miguelgfierro
python 3.6+ in requires
4f99875
@miguelgfierro
Delete conda and requirement scripts not used anymore
c1027f8
@miguelgfierro
Delete tools/generate_requirements_txt.py
0dd891b
@miguelgfierro
Merge pull request #1988 from recommenders-team/simonz-dep-upgrade-20…
8d67ef5 
…230905

Remove support for Python 3.7
@miguelgfierro
Merge branch 'staging' into miguel/new_test_categories
cd6cc35
@miguelgfierro
Changed test_dataset to test_download_utils FYI @looklike
5457f50 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
miguelgfierro and others added 23 commits September 17, 2023 09:09
@miguelgfierro
unit models
c26a6a3 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
unit tuning
66e6dca 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
unit utils
3cdb4d3 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
📝
0fbbec1 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
🐛
c40ffce 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
🐛
de11824 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
🐛
e26f4ff 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Update readme tests
fdee579 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
License file changed so the maybe download tests had to be updated
54b171b 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
📝
1c1e1e4 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
ignoring one of the lightfm for a weird error
0d17767 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Merge pull request #1989 from recommenders-team/miguel/new_test_categ…
399f1c5 
…ories

Refactor tests into new categories reviewed by Eric Gamma
@miguelgfierro
datasets with Sgit st!
c5f1e78 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Added init to fix import error
1b742c3 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
update repo url
0d8ce18 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
ignore xlearn
4489f18 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Add init files
05e64bd 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
update info from MS
29ddb1a 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
update info from MS
c8e4da0 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
📝
577e87e 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@anargyri
Minor syntax in README
aef5458
@miguelgfierro
📝
817d288 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Merge pull request #1995 from recommenders-team/bug/new_tests
6a2b0a3 
BUG in new tests
@miguelgfierro miguelgfierro merged commit 2aca74f into main Sep 26, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anargyri anargyri anargyri approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miguelgfierro @anargyri @SimonYansenZhao