Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contrib and PR template markdowns #2053

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Jan 7, 2024

Description

I've noticed that in the PR template, when we link ../CONTRIBUTING.md, the link works: https://github.com/recommenders-team/recommenders/blob/main/.github/PULL_REQUEST_TEMPLATE.md

However, in the PRs, the link takes you to the wrong URL: https://github.com/recommenders-team/recommenders/CONTRIBUTING.md

I believe we need to put in the template CONTRIBUTING.md. We will be able to check it when we merge to main.

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro miguelgfierro merged commit 4e9a546 into staging Jan 8, 2024
1 check passed
@miguelgfierro miguelgfierro deleted the miguel/contrib branch January 8, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants