SAR: made tests work for single-node implementation. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @maxkazmsft, tell me which suggestions you can do quickly. Those that are not a priority can be fixed later and we can add an issue to remember that we need to fix them |
scripts/generate_conda_file.sh
Outdated
| @@ -99,6 +99,7 @@ ${pyspark}- pyspark==2.2.0 | |||
| - pylint>=2.0.1 | |||
| - pytest-pylint==0.11.0 | |||
| - papermill>=0.15.0 | |||
| - urllib3>=2.13 | |||
There was a problem hiding this comment.
Can you confirm we need this one? I used urllib for this file.
There was a problem hiding this comment.
Good catch - yes, we don't need it
miguelgfierro
approved these changes
Oct 10, 2018
WessZumino
pushed a commit
that referenced
this pull request
Nov 28, 2018
SAR: made tests work for single-node implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.