AUC and Logloss #580

yueguoguo · 2019-02-28T07:57:43Z

Description

Discussed with @Leavingseason and added

AUC metric
Logloss metric

Related Issues

#445

Checklist:

My code follows the code style of this project, as detailed in our contribution guidelines.
I have added tests.
I have updated the documentation accordingly.

yueguoguo · 2019-02-28T08:09:41Z

Updates in the notebooks will be given in another PR for the convenience of review.

miguelgfierro

hey @yueguoguo this is good, but there is a problem with the way we are using fixtures, please see comments

reco_utils/evaluation/python_evaluation.py

tests/unit/test_python_evaluation.py

reco_utils/evaluation/python_evaluation.py

tests/unit/test_python_evaluation.py

AUC and Logloss

yueguoguo added 8 commits February 28, 2019 06:51

EVALUATION: add placeholders for auc/logloss

fab0866

EVALUATION: add roc and logloss

0b07fef

TEST: add test for auc

be2c09d

TEST: add auc test"

a121380

TEST: module scope at fixture

19fed9e

EVALUATION: range of logloss

c4d82ef

TEST: add logloss test

17de9c2

TEST: type conversion to avoid warning

b51e4e8

yueguoguo requested a review from miguelgfierro as a code owner February 28, 2019 07:57

yueguoguo modified the milestones: Benchmarking, Deep Learning Based Recommender Scenario, Hyperparameter tuning on AzureML Feb 28, 2019

TEST: function not iterable

61cd68c

yueguoguo mentioned this pull request Feb 28, 2019

[FEATURE] Update evaluation / xDeepFM / DKN notebooks #581

Closed

TEST: typo in target metrics

7c4e546

yueguoguo requested review from anargyri and Leavingseason February 28, 2019 09:13

miguelgfierro requested changes Feb 28, 2019

View reviewed changes

reco_utils/evaluation/python_evaluation.py Outdated Show resolved Hide resolved

reco_utils/evaluation/python_evaluation.py Show resolved Hide resolved

tests/unit/test_python_evaluation.py Show resolved Hide resolved

tests/unit/test_python_evaluation.py Outdated Show resolved Hide resolved

EVALUATION: use .values to make it faster 🚀

a0e0a18

miguelgfierro approved these changes Feb 28, 2019

View reviewed changes

tests/unit/test_python_evaluation.py Show resolved Hide resolved

yueguoguo and others added 2 commits February 28, 2019 16:05

TEST: explicit is preferred :love:

01bf089

Remove unused comments

9fab06d

yueguoguo merged commit 507ca9f into staging Mar 1, 2019

yueguoguo deleted the le_auc_logloss branch March 1, 2019 02:39

yueguoguo mentioned this pull request Mar 1, 2019

AUC logloss doc #591

Merged

3 tasks