Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lgbm o16n tuning pass #735

Merged
merged 11 commits into from
Apr 16, 2019
Merged

lgbm o16n tuning pass #735

merged 11 commits into from
Apr 16, 2019

Conversation

jreynolds01
Copy link
Collaborator

@jreynolds01 jreynolds01 commented Apr 11, 2019

Description

Adjusted spark serving params to be better tuned.

Adjusted AksWebservice configuration to meet a load demand and added documentation about how to decide what values to choose.

Related Issues

N/A

Checklist:

  • [X ] My code follows the code style of this project, as detailed in our contribution guidelines.
  • I have added tests.
  • [X ] I have updated the documentation accordingly.

@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/Microsoft/Recommenders/pull/735

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@@ -122,6 +122,8 @@
"from azureml.core.image import ContainerImage\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to have some of the results from Devops of request time. We can also add that image to the OKR document

Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the scenario doc is the better place for that, but it's probably worth adding a cell with the results here at the very end. Will try to get to that later today.


Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice, just some small comments

reco_utils/azureml/aks_utils.py Outdated Show resolved Hide resolved
reco_utils/azureml/aks_utils.py Outdated Show resolved Hide resolved
@jreynolds01 jreynolds01 merged commit 1da5b4f into staging Apr 16, 2019
@miguelgfierro miguelgfierro deleted the jr-lgbm-o16n-tuning-pass branch May 25, 2019 07:46
yueguoguo pushed a commit that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants