Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve normalization performance #922

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Improve normalization performance #922

merged 1 commit into from
Sep 10, 2019

Conversation

zegerius
Copy link
Contributor

Co-authored-by: @Overv

Description

PR #914 did not include the performance of the normalization. By following the same improvements, normalization now has similar performance.

We also included a way to trigger normalization for the recommend_k_items-call, by adding the normalize kwarg.

Related Issues

#907

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.

gramhagen
gramhagen approved these changes Sep 10, 2019
View reviewed changes
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches!

@gramhagen gramhagen merged commit 4af8a2a into recommenders-team:staging Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramhagen gramhagen gramhagen approved these changes

@miguelgfierro miguelgfierro Awaiting requested review from miguelgfierro miguelgfierro is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zegerius @gramhagen