Make reconciliation score optional #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfmorris
reviewed
Jul 13, 2023
There was a problem hiding this comment.
I don't have a strong objection to this, but it does seem like the spec is pulling in two different directions at once by introducing micro feature scores that a client needs to sum up / average while at the same time making the overall score optional.
As a user, I'm interested in easy to interpret, useful information to help efficiently review match candidates, including automatically accepting high confidence matches.
paulgirard
requested changes
Jul 20, 2023
fsteeg
reviewed
Sep 11, 2023
Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
fsteeg
approved these changes
Sep 11, 2023
tfmorris
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127.