Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description of changes in the current draft #162

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

wetneb
Copy link
Member

@wetneb wetneb commented Apr 5, 2024

Also closes #144.

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for reconciliation-api-specs ready!

Name Link
🔨 Latest commit cb558a5
🔍 Latest deploy log https://app.netlify.com/sites/reconciliation-api-specs/deploys/6617bb389e59ad00081603eb
😎 Deploy Preview https://deploy-preview-162--reconciliation-api-specs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great overview 👍

Pushed two typo fixes and added PR (#166) for unified camelCase (#150).

@fsteeg fsteeg merged commit f3e9bc5 into master Apr 11, 2024
5 checks passed
@fsteeg fsteeg deleted the update-changelog branch April 11, 2024 14:42
wetneb pushed a commit that referenced this pull request Jun 13, 2024
* Unify naming to camelCase convention (#150)

While snake_case took over in the draft, camelCase is the common
convention in the manifest, so this seems to be the sensible choice

* Update draft examples and schemas for removed fields

Noticed while unifying naming for #150

* Update "This Draft" section for camelCase naming (#150, #162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix list punctuation
2 participants