Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epiweek for interval option #89

Closed
aspina7 opened this issue Dec 11, 2018 · 1 comment · Fixed by #110
Closed

Add epiweek for interval option #89

aspina7 opened this issue Dec 11, 2018 · 1 comment · Fixed by #110
Assignees

Comments

@aspina7
Copy link

aspina7 commented Dec 11, 2018

Hey,

Speaking to people at WHO on the course and the standard epiweek from CDC starts on a sunday. It would be good if interval = "epiweek" could be added as one of the options for interval where it defaults to a week starting on a sunday.

Possibly as well it would be nice to be able to put in Mon, Tues, Wed, Thurs ... to define the start day of the week.

I know you can put the start_date to solve these problems but I think this would be easier for the end user.

@caijun
Copy link
Collaborator

caijun commented Dec 11, 2018

Also see the discussions in #24 and #55

The US CDC uses MMWRweek.

Currently interval = week refers to ISO week, the first day of which is Monday. It should be easy to support MMWR week. The week values for interval can be "ISOweek" and "MMWRweek", or other week formats that would be supported in the future.

@zkamvar zkamvar self-assigned this Jan 7, 2019
zkamvar added a commit that referenced this issue Feb 26, 2019
This begins to address #89
zkamvar added a commit that referenced this issue Mar 6, 2019
@zkamvar zkamvar mentioned this issue Mar 12, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants