Check gitter enabled attribute

config-template.json

@@ -46,6 +46,7 @@
   },
   "integrations": {
     "gitter": {
+      "enabled": false,
       "token": "yourpersonaltoken",
       "roomId": "yourroomid"
     },

src/Controllers/Clients/CreateClientController.php

@@ -5,22 +5,34 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Reconmap\Controllers\Controller;
+use Reconmap\Models\AuditActions\ClientAuditActions;
 use Reconmap\Models\Client;
 use Reconmap\Repositories\ClientRepository;
+use Reconmap\Services\ActivityPublisherService;
 
 class CreateClientController extends Controller
 {
-    public function __construct(private readonly ClientRepository $repository)
+    public function __construct(private readonly ClientRepository $repository, private readonly ActivityPublisherService $activityPublisherService)
     {
     }
 
     public function __invoke(ServerRequestInterface $request): ResponseInterface
     {
+        $loggedInUserId = $request->getAttribute('userId');
+
         /** @var Client $client */
         $client = $this->getJsonBodyDecodedAsClass($request, new Client());
-        $client->creator_uid = $request->getAttribute('userId');
+        $client->creator_uid = $loggedInUserId;
 
         $client->id = $this->repository->insert($client);
+
+        $this->auditAction($loggedInUserId, $client);
+
         return $this->createStatusCreatedResponse($client);
     }
+
+    private function auditAction(int $loggedInUserId, Client $client): void
+    {
+        $this->activityPublisherService->publish($loggedInUserId, ClientAuditActions::CREATED, ['type' => 'client', 'id' => $client->id, 'name' => $client->name]);
+    }
 }

src/Controllers/Clients/DeleteClientController.php

@@ -11,8 +11,8 @@
 class DeleteClientController extends Controller
 {
     public function __construct(
-        private ClientRepository         $repository,
-        private ActivityPublisherService $activityPublisherService)
+        private readonly ClientRepository         $repository,
+        private readonly ActivityPublisherService $activityPublisherService)
     {
     }
 

src/Integrations/GitterIntegration.php

@@ -2,11 +2,12 @@
 
 namespace Reconmap\Integrations;
 
+use GuzzleHttp\Client;
 use Reconmap\Services\ApplicationConfig;
 
 class GitterIntegration implements Integration, ActivityPublisher
 {
-    public function __construct(private ApplicationConfig $config)
+    public function __construct(private readonly ApplicationConfig $config)
     {
     }
 
@@ -33,7 +34,11 @@ public function publishActivity(string $activity): void
 
         $configuration = (object)$this->getConfiguration();
 
-        $client = new \GuzzleHttp\Client(['base_uri' => 'https://api.gitter.im/v1']);
+        if (!$configuration->enabled) {
+            return;
+        }
+
+        $client = new Client(['base_uri' => 'https://api.gitter.im/v1']);
         $client->request('POST', '/v1/rooms/' . $configuration->roomId . '/chatMessages', [
             'headers' => ['Authorization' => 'Bearer ' . $configuration->token],
             'json' => [

src/Models/AuditActions/AuditLogAction.php

@@ -14,8 +14,8 @@ class AuditLogAction implements
     VulnerabilityLogActions,
     VulnerabilityCategoryLogActions
 {
-    public const DATA_IMPORTED = 'Imported data';
-    public const DATA_EXPORTED = 'Exported data';
+    public const string DATA_IMPORTED = 'Imported data';
+    public const string DATA_EXPORTED = 'Exported data';
 
-    public const ORGANISATION_UPDATED = 'Updated organisation';
+    public const string ORGANISATION_UPDATED = 'Updated organisation';
 }

src/Models/AuditActions/ClientAuditActions.php

@@ -4,7 +4,7 @@
 
 interface ClientAuditActions
 {
-    public const CREATED = 'Created client';
-    public const UPDATED = 'Updated client';
-    public const DELETED = 'Deleted client';
+    public const string CREATED = 'Created client';
+    public const string UPDATED = 'Updated client';
+    public const string DELETED = 'Deleted client';
 }

tests/Controllers/Clients/CreateClientControllerTest.php

@@ -5,8 +5,10 @@
 use Fig\Http\Message\StatusCodeInterface;
 use PHPUnit\Framework\TestCase;
 use Psr\Http\Message\ServerRequestInterface;
+use Reconmap\Models\AuditActions\ClientAuditActions;
 use Reconmap\Models\Client;
 use Reconmap\Repositories\ClientRepository;
+use Reconmap\Services\ActivityPublisherService;
 
 class CreateClientControllerTest extends TestCase
 {
@@ -33,7 +35,12 @@ public function testHappyPath()
             ->method('getBody')
             ->willReturn('{"name":"exciting new client","address":"evergreen","url":"1.1.1.1"}');
 
-        $controller = new CreateClientController($mockProjectRepository);
+        $mockActivityPublisherService = $this->createMock(ActivityPublisherService::class);
+        $mockActivityPublisherService->expects($this->once())
+            ->method('publish')
+            ->with(9, ClientAuditActions::CREATED, ['type' => 'client', 'id' => 1, 'name' => $expectedClient->name]);
+
+        $controller = new CreateClientController($mockProjectRepository, $mockActivityPublisherService);
         $response = $controller($mockRequest);
 
         $this->assertEquals(StatusCodeInterface::STATUS_CREATED, $response->getStatusCode());