Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stderr #62

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Stderr #62

merged 2 commits into from
Nov 7, 2022

Conversation

landure
Copy link
Contributor

@landure landure commented Oct 28, 2022

This pull request fix #57.

I've refactored the code to use the same logic for @stdin, @stdout and @stderr.
I've added complexity to allow for multiple lines @std* messages to be added base on indentation.
The messages are trimmed and indentation is lost to return to the same alignment.
I've added unit tests specific to the changes, but no previous unit tests were failed.

This silently fix an issue where @stdoutsomething was seen as @stdout (same apply for @stdinsomething).

@kovetskiy kovetskiy merged commit c34dbfb into reconquest:master Nov 7, 2022
landure added a commit to landure/shdoc that referenced this pull request Aug 17, 2023
@landure
Stderr (reconquest#62)
f3fe2eb 
* Close reconquest#57, add @stderr tag, refactoring of @stdout and @stderr.
@stderr, @stdout and @stdin uses the same code, with multiples lines
support.

* Add unit tests and update example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: Add support for @stderr
2 participants
@landure @kovetskiy