Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct API missing 3D Affine Transform #316

Closed
FrostKiwi opened this issue Jun 15, 2023 · 5 comments
Closed

Struct API missing 3D Affine Transform #316

FrostKiwi opened this issue Jun 15, 2023 · 5 comments

Comments

@FrostKiwi
Copy link
Contributor

I found both...

glm_mul_rot(mat4 m1, mat4 m2, mat4 dest) {

glm_inv_tr(mat4 mat) {

...to be very useful optimizations and use them in my camera calculation code. I recently switched to the struct API and found them to be missing, requiring me to use

glm_mul_rot(gctx.cam.view_matrix.raw, gctx.cam.cam_rotation_matrix.raw,
	gctx.cam.view_matrix.raw);
glm_inv_tr(gctx.cam.view_matrix.raw);

Would be really nice if they could be added to the struct api.

@recp
Copy link
Owner

recp commented Jun 15, 2023

Wow yes indeed we should add them to struct api (affine-mat.h), a PR would be nice to bring these to struct api otherwise I'll do asap :)

@FrostKiwi
Copy link
Contributor Author

Wow yes indeed we should add them to struct api (affine-mat.h), a PR would be nice to bring these to struct api otherwise I'll do asap :)

Kinda hacked it into my codebase already. I'll make a PR later this evening.

@recp
Copy link
Owner

recp commented Jun 15, 2023

@FrostKiwi thanks 🤗

@FrostKiwi
Copy link
Contributor Author

@FrostKiwi thanks 🤗

@recp added in PR #317

@recp
Copy link
Owner

recp commented Jun 15, 2023

Since the PR is merged, I'm going to close this issue, feel free to bring any issues, ideas, feedbacks, contributions ..

Thanks

@recp recp closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants