Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing 3D Affine Transforms in the Struct API #317

Merged
merged 4 commits into from Jun 15, 2023

Conversation

FrostKiwi
Copy link
Contributor

This PR solves #316 by adding three 3D Affine Transform functions, which were previously missing from the struct api:

CGLM_INLINE mat4s glms_mul(mat4 m1, mat4 m2);
CGLM_INLINE mat4s glms_mul_rot(mat4 m1, mat4 m2);
CGLM_INLINE mat4s glms_inv_tr();

@recp
Copy link
Owner

recp commented Jun 15, 2023

@FrostKiwi many thanks for bringing missing features to strut API. One thing, we need to add this new file to build files.

@FrostKiwi
Copy link
Contributor Author

@FrostKiwi many thanks for bringing missing features to strut API. One thing, we need to add this new file to build files.

Added to the Makefile via c4d4c48 and to the Visual Studio project files via a7cda7f. I put it into separate commits, for a convenient revert, in case I was not supposed do one of them.

@recp recp merged commit 2bbaeb8 into recp:master Jun 15, 2023
1 check passed
@recp
Copy link
Owner

recp commented Jun 15, 2023

@FrostKiwi thanks for your contributions, the PR is merged 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants