Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CMAKE_BINARY_DIR to CMAKE_CURRENT_BINARY_DIR for cmake.pc #270

Merged
merged 1 commit into from Dec 13, 2022

Conversation

suicvne
Copy link

@suicvne suicvne commented Dec 13, 2022

While attempting to deploy a Qt project that depends on CGLM, I got an error about being unable to find cglm.pc:

-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/types-struct.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/types.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/util.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/vec2-ext.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/vec2.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/vec3-ext.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/vec3.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/vec4-ext.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/vec4.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/include/cglm/version.h
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/lib/cmake/cglm/cglmConfig.cmake
-- Installing: C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/../install/lib/cmake/cglm/cglmConfig-debug.cmake
CMake Error at libs/cascade/src/libCascade/cglm/cmake_install.cmake:67 (file):
  file INSTALL cannot find
  "C:/MAM/git/csc/concept_editor/build-CascadeEditorConcept1-NO_RTC_Qt_6_4_0_MSVC2022_64bit-Debug/cglm.pc":
  File exists.
Call Stack (most recent call first):
  libs/cascade/src/libCascade/cmake_install.cmake:37 (include)
  libs/cascade/cmake_install.cmake:37 (include)
  cmake_install.cmake:62 (include)

cglm.pc did not exist at the given path. The project was added as a subdirectory and given a custom build path, where cglm.pc actually was. Changing ${CMAKE_BINARY_DIR} to ${CMAKE_CURRENT_BINARY_DIR} in CMakeLists.txt fixed the deployment for Qt.

@recp recp merged commit 3894ea3 into recp:master Dec 13, 2022
@recp
Copy link
Owner

recp commented Dec 13, 2022

Hi @suicvne, that makes sense, thanks for your contribution[s], the PR is merged 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants