Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mat4: add new function glm_mat4_make #299

Merged
merged 1 commit into from
May 15, 2023

Conversation

EasyIP2023
Copy link
Contributor

Let me know if I'm missing anything please.

@recp
Copy link
Owner

recp commented May 14, 2023

@EasyIP2023 thanks for the PR,

What about glm_mat2_make, glm_mat3_make? also we have struct api it would be nice to add this to there too

@recp recp mentioned this pull request May 14, 2023
@EasyIP2023
Copy link
Contributor Author

@recp Will add glm_mat2_make and glm_mat3_make in separate PR's. Adding to struct api and rebasing.

@EasyIP2023 EasyIP2023 force-pushed the feature/glm_mat4_make branch 2 times, most recently from b9970b9 to 2d2f4dd Compare May 14, 2023 21:11
Copy link
Owner

@recp recp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also docs/ and tests would be nice for new funcs if possible.

include/cglm/struct/mat4.h Outdated Show resolved Hide resolved
@EasyIP2023 EasyIP2023 force-pushed the feature/glm_mat4_make branch 2 times, most recently from 9999b91 to 3624d2a Compare May 15, 2023 00:33
Function takes in a 16 element float array
and converts it into a mat4 matrix.

Signed-off-by: Vincent Davis Jr <vince@underview.tech>
@recp recp merged commit 7346e91 into recp:master May 15, 2023
@recp
Copy link
Owner

recp commented May 15, 2023

@EasyIP2023 thanks for your contribution[s], the PR is merged now 🚀

@EasyIP2023 EasyIP2023 deleted the feature/glm_mat4_make branch May 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants