test_quat: add more robust quat_make test #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasyIP2023
changed the title
Makes it so that it's easier to identify the potential usecase of function. Commit also includes a fix to the struct/quat.h glms_quat_make comment. Should be returning versors it's not a void function. Signed-off-by: Vincent Davis Jr <vince@underview.tech>
EasyIP2023
force-pushed
the
feture/update-test_quat-glm_quat_make
branch
from
ff603df
to
5e798a9
Compare
|
@EasyIP2023 many thanks for your contributions, the PR is merged 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that it's easier to identify
the potential use case of function. Commit also
includes a fix to the struct/quat.h glms_quat_make comment.
Should be returning versors it's not
a void function.