Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct API glms_ray_at incorrect dir param. #402

Merged
merged 1 commit into from Mar 29, 2024

Conversation

nitrix
Copy link
Contributor

@nitrix nitrix commented Mar 28, 2024

Fixes what appears to me like an accidental copy-paste mistake with the dir parameter of the struct API for glms_ray_at().
Introduced in 73a4fc7 (v0.9.3), discovered during compilation by Clang warnings.

[build] ***/vendor/cglm/include/cglm/struct/ray.h:76:33: warning: unused parameter 'dir' [-Wunused-parameter]
[build] glms_ray_(at)(vec3s orig, vec3s dir, float t) {
[build]                                 ^
[build] 1 warning generated.

@recp recp merged commit 55521ec into recp:master Mar 29, 2024
74 checks passed
@recp
Copy link
Owner

recp commented Mar 29, 2024

Hi @nitrix,

Thanks for the catch and your contributions, the PR is merged 🚀

@nitrix nitrix deleted the fix/struct-api-ray-at branch March 30, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants