Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright test impl #16

Merged
merged 12 commits into from
Sep 18, 2023
Merged

Playwright test impl #16

merged 12 commits into from
Sep 18, 2023

Conversation

AkifumiSato
Copy link
Contributor

@AkifumiSato AkifumiSato commented Sep 17, 2023

  • playwright環境構築、テストケースの追加、CI構築をしました
  • pages router+Safariが実際の動作では復元できるんですが、playwrightだと失敗するので一旦skipするようにしています

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2023

⚠️ No Changeset found

Latest commit: 2409a73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AkifumiSato AkifumiSato marked this pull request as ready for review September 17, 2023 14:55
Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっとコメントしたけどLGTM!

- name: Install packages
run: pnpm i --ignore-scripts
- name: Install playwright browsers
run: npx playwright install --with-deps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpmを使ってるのにnpxpnpm dlxではダメなのん?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。
2409a73

"lint": "next lint"
"lint": "next lint",
"integration-test": "npx playwright test",
"integration-test:ui": "npx playwright test --ui"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。
2409a73

import { test, expect } from "@playwright/test";
import { describe } from "node:test";

// Safari/Firefox: different from actual movement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

しょうもないことで申し訳ないけどmovementよりはbehaviorの方がらしいのでは?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。
2409a73

import { test, expect } from "@playwright/test";
import { describe } from "node:test";

// Safari/Firefox: different from actual movement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。
2409a73

@AkifumiSato AkifumiSato merged commit c907863 into main Sep 18, 2023
2 checks passed
@AkifumiSato AkifumiSato deleted the integration-test branch September 18, 2023 08:37
@AkifumiSato
Copy link
Contributor Author

pages router+Safariが実際の動作では復元できるんですが、playwrightだと失敗するので一旦skipするようにしています

マージ後ですいません、
これ調べたらどうもplaywright上のSafariでブラウザバックがMPA遷移になってました。
公式のDiscordで相談してますがちょっと時間かかりそうor解決できなそうです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants