-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwright test impl #16
Conversation
AkifumiSato
commented
Sep 17, 2023
•
edited
Loading
edited
- playwright環境構築、テストケースの追加、CI構築をしました
- pages router+Safariが実際の動作では復元できるんですが、playwrightだと失敗するので一旦skipするようにしています
|
d2abae5
to
e4db9d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ちょっとコメントしたけどLGTM!
.github/workflows/playwright.yml
Outdated
- name: Install packages | ||
run: pnpm i --ignore-scripts | ||
- name: Install playwright browsers | ||
run: npx playwright install --with-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm
を使ってるのにnpx
? pnpm dlx
ではダメなのん?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました。
2409a73
apps/example-next/package.json
Outdated
"lint": "next lint" | ||
"lint": "next lint", | ||
"integration-test": "npx playwright test", | ||
"integration-test:ui": "npx playwright test --ui" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました。
2409a73
import { test, expect } from "@playwright/test"; | ||
import { describe } from "node:test"; | ||
|
||
// Safari/Firefox: different from actual movement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
しょうもないことで申し訳ないけどmovementよりはbehaviorの方がらしいのでは?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました。
2409a73
import { test, expect } from "@playwright/test"; | ||
import { describe } from "node:test"; | ||
|
||
// Safari/Firefox: different from actual movement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました。
2409a73
マージ後ですいません、 |