Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rm root dependencies navigation-api-types, @types/react-dom #399

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

AkifumiSato
Copy link
Contributor

rootにはツール系と@types/nodeのみ残しました。
tsupとかは分散させてもいいかと思ったんですが、あまり問題が起きるとも思えなかったのでままにしています。

@AkifumiSato AkifumiSato requested a review from koichik June 20, 2024 13:22
Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 9c71869

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AkifumiSato AkifumiSato force-pushed the refactor-package-dependencies branch from 4aae83f to 9c71869 Compare June 20, 2024 13:23
Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AkifumiSato AkifumiSato merged commit b89a92c into main Jun 20, 2024
2 checks passed
@AkifumiSato AkifumiSato deleted the refactor-package-dependencies branch June 20, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants