test: simulate Static/SSG rendering properely

recruit-tech · Jul 16, 2022 · bd8c1a8 · bd8c1a8
1 parent 9a2a8ac
commit bd8c1a8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/url/RecoilURLSyncJSONNext.test.tsx b/src/url/RecoilURLSyncJSONNext.test.tsx
@@ -77,11 +77,12 @@ describe('<RecoilURLSyncJSONNext />', () => {
           await waitFor(() =>
             expect(getByTestId('foo').textContent).toBe('FooFoo')
           )
-          urlPath = mockRouter.asPath
         })
 
         describe('then, navigate (pushstate)', () => {
           beforeEach(() => {
+            urlPath = mockRouter.asPath // save current URL before push()
+
             act(() => {
               mockRouter.push('/next')
             })
@@ -159,11 +160,12 @@ describe('<RecoilURLSyncJSONNext />', () => {
           await waitFor(() =>
             expect(getByTestId('foo').textContent).toBe('BarFoo')
           )
-          urlPath = mockRouter.asPath
         })
 
         describe('then, navigate (pushstate)', () => {
           beforeEach(() => {
+            urlPath = mockRouter.asPath // save current URL before push()
+
             act(() => {
               mockRouter.push('/next')
             })
@@ -239,6 +241,10 @@ describe('<RecoilURLSyncJSONNext />', () => {
         beforeEach(() => {
           act(() => {
             mockRouter.isReady = true
+            // because mockRouter holds router's snapshot into useState(),
+            // we need to fire 'routeChangeComplete' event to update the snapshot.
+            // otherwise isReady will not be reflected.
+            mockRouter.events.emit('routeChangeComplete')
             rerender(
               <App>
                 <Child />
@@ -264,11 +270,12 @@ describe('<RecoilURLSyncJSONNext />', () => {
             await waitFor(() =>
               expect(getByTestId('foo').textContent).toBe('BarFoo')
             )
-            urlPath = mockRouter.asPath
           })
 
           describe('then, navigate (pushstate)', () => {
             beforeEach(() => {
+              urlPath = mockRouter.asPath // save current URL before push()
+
               act(() => {
                 mockRouter.push('/next')
               })

diff --git a/src/url/RecoilURLSyncTransitNext.test.tsx b/src/url/RecoilURLSyncTransitNext.test.tsx
@@ -82,11 +82,12 @@ describe('<RecoilURLSyncTransitNext />', () => {
           await waitFor(() =>
             expect(getByTestId('foo').textContent).toBe('FooFoo')
           )
-          urlPath = mockRouter.asPath
         })
 
         describe('then, navigate (pushstate)', () => {
           beforeEach(() => {
+            urlPath = mockRouter.asPath // save current URL before push()
+
             act(() => {
               mockRouter.push('/next')
             })