Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate atom key warnings (finally) #122

Merged
merged 2 commits into from Oct 16, 2022
Merged

Avoid duplicate atom key warnings (finally) #122

merged 2 commits into from Oct 16, 2022

Conversation

koichik
Copy link
Member

@koichik koichik commented Oct 15, 2022

Use RecoilEnv.RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED introduced by Recoil v0.7.6

AkifumiSato
AkifumiSato approved these changes Oct 16, 2022
View reviewed changes
Copy link
Collaborator

@AkifumiSato AkifumiSato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ついに...！
LGTM

@koichik koichik merged commit 8361687 into main Oct 16, 2022
@koichik koichik deleted the avoid-duplicate-atom-key-warnings branch October 16, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkifumiSato AkifumiSato AkifumiSato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koichik @AkifumiSato