Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples(RHF): support for default{Value,Checked} & useFieldArray #134
examples(RHF): support for default{Value,Checked} & useFieldArray #134
Changes from all commits
12b2310
0a1dd78
7ef325a
802a81b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo: RHFの
useFieldArray
はimportして使うと思うので、↓みたくしてimprot { useFieldArraySync }
して使うというのは微妙ですかね?その方がhooksっぽいかなって気もしたものの、自信ないのでご意見いただきたいです🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最初はまさにそのつもりだったのですが、将来
onChangeForm()
以外を渡さないといけなくなる可能性を考えると最初からクロージャにしちゃった方がいいだろうと思いました別案としては
useFormSync()
からラップしたcontrol
を返してそれをuseFieldArraySync()
に渡すというのも考えたのですが、ラップするオブジェクトが増え続けるのもどうかかと思いクロージャ案を選びましたuseFormSync()
するコンポーネントとuseFieldArraySync()
するコンポーネントが分かれる場合はcontrol
をラップするのが一番使い勝手がいい気はします他の2案では
control
に加えてuseFieldArraySync
かonChangeForm
のどちらかも一緒に子コンポーネントに渡さないといけないのでThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これの結論が出るまでマージ保留にします
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かにですね...
方針納得しました!
一応知っておきたいんですが、ラップするというのは↓みたいなイメージであってますか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そのイメージです
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
とのことなのでこれでマージします!