New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose shallow routing as a prop. #139
Conversation
Thanks, really nice catch! |
Thank you! I agree I think I can't see many use cases where you would want to run gSSP after updating a recoil value over just having the value stored into the URL. For my use case, I am using URL sync as a way to preserve the state of the page if someone copy-pastes the link to share the page with someone else. I updated the PR. Let me know what you think. |
I agree! Thus, I don't think we need to add |
I see what you mean now. I have updated it to always use shallow push for |
Thanks! Also, can you remove |
README should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for your contribution! |
Shallow routing can be useful if you just want to sync the atom into the URL without refreshing the page.