Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid lost the state when navigate to the same URL #57

Merged
merged 1 commit into from
Jul 29, 2022
Merged

fix: avoid lost the state when navigate to the same URL #57

merged 1 commit into from
Jul 29, 2022

Conversation

koichik
Copy link
Member

@koichik koichik commented Jul 23, 2022

reproduce:

  • yarn dev on examples/history-sync-json.
  • open http://localhost:3000/.
  • modify the form on the Top page.
  • click the Top link.
  • the form losts the states (unexpected).

@koichik koichik requested a review from AkifumiSato July 23, 2022 09:41
AkifumiSato
AkifumiSato approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@AkifumiSato AkifumiSato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@koichik koichik merged commit 00a609d into main Jul 29, 2022
@koichik koichik deleted the fix-lost-state-same-url branch July 29, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkifumiSato AkifumiSato AkifumiSato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koichik @AkifumiSato