[TypeDeclaration] Skip default not array type on StrictArrayParamDimF…

…etchRector (#5259)

* [TypeDeclaration] Skip default not array type on StrictArrayParamDimFetchRector

* fixed 🎉

rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_default_not_array_type.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class SkipDefaultNotArrayType
+{
+    public function run($param = 'foo')
+    {
+	 if (isset($param['bar'])) {
+            echo $param['bar'];
+        }
+
+        echo $param;
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/with_default_not_array_type.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class WithDefaultArrayType
+{
+    public function run($param = [])
+    {
+	 if (isset($param['bar'])) {
+            echo $param['bar'];
+        }
+
+        echo $param;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class WithDefaultArrayType
+{
+    public function run(array $param = [])
+    {
+	 if (isset($param['bar'])) {
+            echo $param['bar'];
+        }
+
+        echo $param;
+    }
+}
+
+?>

rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php

@@ -5,6 +5,7 @@
 namespace Rector\TypeDeclaration\Rector\ClassMethod;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\AssignOp\Coalesce as AssignOpCoalesce;
 use PhpParser\Node\Expr\BinaryOp\Coalesce;
@@ -87,6 +88,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($param->default instanceof Expr && ! $this->getType($param->default)->isArray()->yes()) {
+                continue;
+            }
+
             if (! $this->isParamAccessedArrayDimFetch($param, $node)) {
                 continue;
             }