[CodeQuality] Handle all if,elseif,else no bracket on CompleteMissing…

…IfElseBracketRector (#5129)

rules-tests/CodeQuality/Rector/If_/CompleteMissingIfElseBracketRector/Fixture/all_no_bracket.php.inc

@@ -0,0 +1,38 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\CompleteMissingIfElseBracketRector\Fixture;
+
+class AllNoBracket
+{
+    public function run($value)
+    {
+        if ($value)
+            return 1;
+        elseif (rand(0, 1))
+            return 2;
+        else
+            return 3;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\CompleteMissingIfElseBracketRector\Fixture;
+
+class AllNoBracket
+{
+    public function run($value)
+    {
+        if ($value) {
+            return 1;
+        } elseif (rand(0, 1)) {
+            return 2;
+        } else {
+            return 3;
+        }
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/If_/CompleteMissingIfElseBracketRector/Fixture/missing_bracket_on_elseif_and_else.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\CompleteMissingIfElseBracketRector\Fixture;
+
+class MissingBracketOnElseIfAndElse
+{
+    public function run($value)
+    {
+        if ($value) {
+            return 1;
+        } elseif (rand(0, 1))
+            return 2;
+        else
+            return 3;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\CompleteMissingIfElseBracketRector\Fixture;
+
+class MissingBracketOnElseIfAndElse
+{
+    public function run($value)
+    {
+        if ($value) {
+            return 1;
+        } elseif (rand(0, 1)) {
+            return 2;
+        }
+        else {
+            return 3;
+        }
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/If_/CompleteMissingIfElseBracketRector/Fixture/skip_direct_semicolon.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\CompleteMissingIfElseBracketRector\Fixture;
+
+class SkipDirectSemicolon
+{
+    public function run($value)
+    {
+        if ($value);
+
+        echo 'something';
+    }
+}

rules/CodeQuality/Rector/If_/CompleteMissingIfElseBracketRector.php

@@ -83,7 +83,11 @@ public function refactor(Node $node): ?Node
     private function isIfConditionFollowedByOpeningCurlyBracket(If_|ElseIf_|Else_ $if, array $oldTokens): bool
     {
         for ($i = $if->getStartTokenPos(); $i < $if->getEndTokenPos(); ++$i) {
-            if ($oldTokens[$i] !== ')') {
+            if (! isset($oldTokens[$i + 1])) {
+                break;
+            }
+
+            if ($oldTokens[$i] !== ')' && ! is_array($oldTokens[$i+1])) {
                 if ($oldTokens[$i] === ';') {
                     // all good
                     return true;