[Privatization] Skip used by heredoc on ChangeReadOnlyVariableWithDef…

…aultValueToConstantRector (#3216)

Co-authored-by: GitHub Action <action@github.com>

rules-tests/Privatization/Rector/Class_/ChangeReadOnlyVariableWithDefaultValueToConstantRector/Fixture/skip_used_by_heredoc.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Class_\ChangeReadOnlyVariableWithDefaultValueToConstantRector\Fixture;
+
+final class SkipUsedByHeredoc
+{
+    public function run()
+    {
+        $foo = 'I like pie';
+
+        $bar = <<<EOD
+And on this day, it was spoken - "$foo"
+
+EOD;
+    }
+}

rules/Renaming/Helper/RenameClassCallbackHandler.php

@@ -5,6 +5,7 @@
 namespace Rector\Renaming\Helper;
 
 use PhpParser\Node;
+use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\ClassLike;
 use PhpParser\NodeVisitorAbstract;
 use PHPStan\Reflection\ReflectionProvider;
@@ -53,18 +54,18 @@ public function getOldToNewClassesFromNode(Node $node): array
     /**
      * @return array<string, string>
      */
-    public function handleClassLike(ClassLike $node): array
+    public function handleClassLike(ClassLike $classLike): array
     {
         $oldToNewClasses = [];
-        $className = $node->name;
-        if ($className === null) {
+        $className = $classLike->name;
+        if (! $className instanceof Identifier) {
             return [];
         }
 
         foreach ($this->oldToNewClassCallbacks as $oldToNewClassCallback) {
-            $newClassName = $oldToNewClassCallback($node, $this->nodeNameResolver, $this->reflectionProvider);
+            $newClassName = $oldToNewClassCallback($classLike, $this->nodeNameResolver, $this->reflectionProvider);
             if ($newClassName !== null) {
-                $fullyQualifiedClassName = (string) $this->nodeNameResolver->getName($node);
+                $fullyQualifiedClassName = (string) $this->nodeNameResolver->getName($classLike);
                 $this->renamedClassesDataCollector->addOldToNewClass($fullyQualifiedClassName, $newClassName);
                 $oldToNewClasses[$fullyQualifiedClassName] = $newClassName;
             }

src/NodeManipulator/ClassMethodAssignManipulator.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Arg;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\ClosureUse;
 use PhpParser\Node\Expr\FuncCall;
@@ -14,6 +15,7 @@
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\FunctionLike;
 use PhpParser\Node\Param;
+use PhpParser\Node\Scalar\Encapsed;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Foreach_;
@@ -66,6 +68,7 @@ public function collectReadyOnlyAssignScalarVariables(ClassMethod $classMethod,
         $readOnlyVariableAssigns = $this->filterOutReferencedVariables($readOnlyVariableAssigns, $classMethod);
         $readOnlyVariableAssigns = $this->filterOutMultiAssigns($readOnlyVariableAssigns);
         $readOnlyVariableAssigns = $this->filterOutForeachVariables($readOnlyVariableAssigns);
+        $readOnlyVariableAssigns = $this->filterOutUsedByEncapsed($readOnlyVariableAssigns);
 
         /**
          * Remove unused variable assign is task of RemoveUnusedVariableAssignRector
@@ -93,6 +96,32 @@ public function addParameterAndAssignToMethod(
         $this->alreadyAddedClassMethodNames[$classMethodHash][] = $name;
     }
 
+    /**
+     * @param Assign[] $readOnlyVariableAssigns
+     * @return Assign[]
+     */
+    private function filterOutUsedByEncapsed(array $readOnlyVariableAssigns): array
+    {
+        $callable = function (Assign $readOnlyVariableAssign): bool {
+            $variable = $readOnlyVariableAssign->var;
+            return ! (bool) $this->betterNodeFinder->findFirstNext(
+                $readOnlyVariableAssign,
+                function (Node $node) use ($variable): bool {
+                    if (! $node instanceof Encapsed) {
+                        return false;
+                    }
+
+                    return (bool) array_filter(
+                        $node->parts,
+                        fn (Expr $expr): bool => $this->nodeComparator->areNodesEqual($expr, $variable)
+                    );
+                }
+            );
+        };
+
+        return array_filter($readOnlyVariableAssigns, $callable);
+    }
+
     /**
      * @param Assign[] $readOnlyVariableAssigns
      * @return Assign[]