[Php72][TypeDeclaration] Fix infinite loop on ParseStrWithResultArgum…

…entRector+DeclareStrictTypesRector (#5699)

* [Php72][TypeDeclaration] Fix infinite loop on ParseStrWithResultArgumentRector+DeclareStrictTypesRector

* [Php72][TypeDeclaration] Fix infinite loop on ParseStrWithResultArgumentRector+DeclareStrictTypesRector

* fix

* fix

* fix

* dont use current()

* fix phpstan

* rename class

* rename class

rules/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector.php

@@ -64,11 +64,13 @@ public function beforeTraverse(array $nodes): ?array
             return null;
         }
 
-        $rootStmt = current($newStmts);
+        // use 0 index to avoid infinite loop
+        $rootStmt = $newStmts[0] ?? null;
         $stmt = $rootStmt;
 
         if ($rootStmt instanceof FileWithoutNamespace) {
-            $currentStmt = current($rootStmt->stmts);
+            // use 0 index to avoid infinite loop
+            $currentStmt = $rootStmt->stmts[0] ?? null;
 
             if (! $currentStmt instanceof Stmt) {
                 return null;
@@ -78,6 +80,10 @@ public function beforeTraverse(array $nodes): ?array
             $stmt = $currentStmt;
         }
 
+        if (! $stmt instanceof Stmt) {
+            return null;
+        }
+
         if ($this->shouldSkip($stmt)) {
             return null;
         }

tests/Issues/InfiniteLoop/DeclareStrictTypesParseStrTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Issues\InfiniteLoop;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class DeclareStrictTypesParseStrTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/FixtureDeclareStrictTypesParseStr');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/declare_strict_types_parsestr.php';
+    }
+}

tests/Issues/InfiniteLoop/FixtureDeclareStrictTypesParseStr/namespaced_same_function.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Foo;
+
+function foo()
+{
+    return 'foo';
+}
+
+echo foo();
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Foo;
+
+function foo()
+{
+    return 'foo';
+}
+
+echo foo();

tests/Issues/InfiniteLoop/FixtureDeclareStrictTypesParseStr/no_namespace_same_function.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+function foo()
+{
+    return 'foo';
+}
+
+echo foo();
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+function foo()
+{
+    return 'foo';
+}
+
+echo foo();
+
+?>

tests/Issues/InfiniteLoop/config/declare_strict_types_parsestr.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php72\Rector\FuncCall\ParseStrWithResultArgumentRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
+
+return RectorConfig::configure()
+    ->withRules([
+        DeclareStrictTypesRector::class,
+        ParseStrWithResultArgumentRector::class,
+    ]);